From 8765044a415eaa071b3bd4217b30057af8dcf5b7 Mon Sep 17 00:00:00 2001 From: CoprDistGit Date: Thu, 7 Aug 2025 06:49:01 +0000 Subject: automatic import of ethtool --- ...ossible-NULL-dereference-in-fec_mode_walk.patch | 39 ++++++++++++++++++++++ 1 file changed, 39 insertions(+) create mode 100644 backport-fix-possible-NULL-dereference-in-fec_mode_walk.patch (limited to 'backport-fix-possible-NULL-dereference-in-fec_mode_walk.patch') diff --git a/backport-fix-possible-NULL-dereference-in-fec_mode_walk.patch b/backport-fix-possible-NULL-dereference-in-fec_mode_walk.patch new file mode 100644 index 0000000..dc3f4f7 --- /dev/null +++ b/backport-fix-possible-NULL-dereference-in-fec_mode_walk.patch @@ -0,0 +1,39 @@ +From 33fffbbdc12d71b3bb23acd04b97ce1b485f3c60 Mon Sep 17 00:00:00 2001 +From: AntonMoryakov +Date: Sun, 18 May 2025 16:18:18 +0300 +Subject: fec: fix possible NULL dereference in fec_mode_walk() + +Static analyzer (Svace) reported a possible null pointer dereference +in fec_mode_walk(), where the 'name' pointer is passed to print_string() +without checking for NULL. + +Although some callers check the return value of get_string(), others +(e.g., walk_bitset()) do not. This patch adds an early NULL check +to avoid dereferencing a null pointer. + +This resolves: +DEREF_OF_NULL.EX.COND: json_print.c:142 via fec.c + +Found by Svace static analysis tool. + +Signed-off-by: Anton Moryakov +--- + netlink/fec.c | 2 ++ + 1 file changed, 2 insertions(+) + +diff --git a/netlink/fec.c b/netlink/fec.c +index 6027dc0..ed100d7 100644 +--- a/netlink/fec.c ++++ b/netlink/fec.c +@@ -27,6 +27,8 @@ fec_mode_walk(unsigned int idx, const char *name, bool val, void *data) + + if (!val) + return; ++ if (!name) ++ return; + if (empty) + *empty = false; + +-- +2.23.0 + -- cgit v1.2.3