1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
|
%global _empty_manifest_terminate_build 0
Name: python-mr-proper
Version: 0.0.7
Release: 1
Summary: Static Python code analyzer, that tries to check if functions in code are pure or not and why.
License: MIT
URL: https://github.com/best-doctor/mr_proper
Source0: https://mirrors.nju.edu.cn/pypi/web/packages/e3/35/a50ba9e3097ee0d71232c996c626a17f80424140b365122c8f1bc9933118/mr_proper-0.0.7.tar.gz
BuildArch: noarch
Requires: python3-click
Requires: python3-setuptools
Requires: python3-stdlib-list
Requires: python3-typing-extensions
%description
# mr. Proper
[](https://travis-ci.org/best-doctor/mr_proper)
[](https://badge.fury.io/py/mr-proper)
[](https://codeclimate.com/github/best-doctor/mr_proper/maintainability)
[](https://codeclimate.com/github/best-doctor/mr_proper/test_coverage)
Static Python code analyzer, that tries to check if functions in code are
[pure](https://en.wikipedia.org/wiki/Pure_function) or not and why.

*DISCLAIMER*: this library is very experimental and has a lot of edge cases.
Functions that mr. Proper marks as pure can be not pure, but they are
usually cleaner than other functions.
## Installation
```bash
pip install mr_proper
```
## What mr. Proper check
1. that function has no blacklisted calls (like `print`)
and blacklisted attributes access (like `smth.count`);
1. that function not uses global objects (only local vars and function arguments);
1. that function has al least one return;
1. that function not mutates it's arguments;
1. that function has no local imports;
1. that function has no arguments of forbidden types (like ORM objects);
1. that function not uses `self`, `class` or `super`;
1. that function has calls of only pure functions.
This list is not enought to say that function is pure and some points
are quite controversial, but it's a nice start.
## Example
Console usage:
```python
# test.py
def add_one(n: int) -> int:
return n + 1
def print_amount_of_users(users_qs: QuerySet) -> None:
print(f'Current amount of users is {users_qs.count()}')
```
```bash
$ mr_propper test.py
add_one is pure!
print_amount_of_users is not pure because of:
it uses forbidden argument types (QuerySet)
it calls not pure functions (print)
it has no return
```
Usage inside Python code sample:
```jupyterpython
>>> import ast
>>> from mr_propper.utils import is_function_pure
>>> funcdef = ast.parse('''
def add_one(n: int) -> int:
return n + 1
''').body[0]
>>> is_function_pure(funcdef)
True
>>> is_function_pure(funcdef, with_errors=True)
(True, [])
```
## Parameters
CLI interface:
- `filepath`: path to .py file to check (directories are not supported for now);
- `--recursive`: require inner calls to be pure for function pureness.
## Code prerequisites
1. Python 3.7+;
1. Functions are fully type-annotated;
1. No dynamic calls (like `getattr(sender, 'send_' + message_type)(message)`).
## Contributing
We would love you to contribute to our project. It's simple:
1. Create an issue with bug you found or proposal you have.
Wait for approve from maintainer.
1. Create a pull request. Make sure all checks are green.
1. Fix review comments if any.
1. Be awesome.
Here are useful tips:
- You can run all checks and tests with `make check`.
Please do it before TravisCI does.
- We use [BestDoctor python styleguide](https://github.com/best-doctor/guides/blob/master/guides/en/python_styleguide.md).
- We respect [Django CoC](https://www.djangoproject.com/conduct/).
Make soft, not bullshit.
%package -n python3-mr-proper
Summary: Static Python code analyzer, that tries to check if functions in code are pure or not and why.
Provides: python-mr-proper
BuildRequires: python3-devel
BuildRequires: python3-setuptools
BuildRequires: python3-pip
%description -n python3-mr-proper
# mr. Proper
[](https://travis-ci.org/best-doctor/mr_proper)
[](https://badge.fury.io/py/mr-proper)
[](https://codeclimate.com/github/best-doctor/mr_proper/maintainability)
[](https://codeclimate.com/github/best-doctor/mr_proper/test_coverage)
Static Python code analyzer, that tries to check if functions in code are
[pure](https://en.wikipedia.org/wiki/Pure_function) or not and why.

*DISCLAIMER*: this library is very experimental and has a lot of edge cases.
Functions that mr. Proper marks as pure can be not pure, but they are
usually cleaner than other functions.
## Installation
```bash
pip install mr_proper
```
## What mr. Proper check
1. that function has no blacklisted calls (like `print`)
and blacklisted attributes access (like `smth.count`);
1. that function not uses global objects (only local vars and function arguments);
1. that function has al least one return;
1. that function not mutates it's arguments;
1. that function has no local imports;
1. that function has no arguments of forbidden types (like ORM objects);
1. that function not uses `self`, `class` or `super`;
1. that function has calls of only pure functions.
This list is not enought to say that function is pure and some points
are quite controversial, but it's a nice start.
## Example
Console usage:
```python
# test.py
def add_one(n: int) -> int:
return n + 1
def print_amount_of_users(users_qs: QuerySet) -> None:
print(f'Current amount of users is {users_qs.count()}')
```
```bash
$ mr_propper test.py
add_one is pure!
print_amount_of_users is not pure because of:
it uses forbidden argument types (QuerySet)
it calls not pure functions (print)
it has no return
```
Usage inside Python code sample:
```jupyterpython
>>> import ast
>>> from mr_propper.utils import is_function_pure
>>> funcdef = ast.parse('''
def add_one(n: int) -> int:
return n + 1
''').body[0]
>>> is_function_pure(funcdef)
True
>>> is_function_pure(funcdef, with_errors=True)
(True, [])
```
## Parameters
CLI interface:
- `filepath`: path to .py file to check (directories are not supported for now);
- `--recursive`: require inner calls to be pure for function pureness.
## Code prerequisites
1. Python 3.7+;
1. Functions are fully type-annotated;
1. No dynamic calls (like `getattr(sender, 'send_' + message_type)(message)`).
## Contributing
We would love you to contribute to our project. It's simple:
1. Create an issue with bug you found or proposal you have.
Wait for approve from maintainer.
1. Create a pull request. Make sure all checks are green.
1. Fix review comments if any.
1. Be awesome.
Here are useful tips:
- You can run all checks and tests with `make check`.
Please do it before TravisCI does.
- We use [BestDoctor python styleguide](https://github.com/best-doctor/guides/blob/master/guides/en/python_styleguide.md).
- We respect [Django CoC](https://www.djangoproject.com/conduct/).
Make soft, not bullshit.
%package help
Summary: Development documents and examples for mr-proper
Provides: python3-mr-proper-doc
%description help
# mr. Proper
[](https://travis-ci.org/best-doctor/mr_proper)
[](https://badge.fury.io/py/mr-proper)
[](https://codeclimate.com/github/best-doctor/mr_proper/maintainability)
[](https://codeclimate.com/github/best-doctor/mr_proper/test_coverage)
Static Python code analyzer, that tries to check if functions in code are
[pure](https://en.wikipedia.org/wiki/Pure_function) or not and why.

*DISCLAIMER*: this library is very experimental and has a lot of edge cases.
Functions that mr. Proper marks as pure can be not pure, but they are
usually cleaner than other functions.
## Installation
```bash
pip install mr_proper
```
## What mr. Proper check
1. that function has no blacklisted calls (like `print`)
and blacklisted attributes access (like `smth.count`);
1. that function not uses global objects (only local vars and function arguments);
1. that function has al least one return;
1. that function not mutates it's arguments;
1. that function has no local imports;
1. that function has no arguments of forbidden types (like ORM objects);
1. that function not uses `self`, `class` or `super`;
1. that function has calls of only pure functions.
This list is not enought to say that function is pure and some points
are quite controversial, but it's a nice start.
## Example
Console usage:
```python
# test.py
def add_one(n: int) -> int:
return n + 1
def print_amount_of_users(users_qs: QuerySet) -> None:
print(f'Current amount of users is {users_qs.count()}')
```
```bash
$ mr_propper test.py
add_one is pure!
print_amount_of_users is not pure because of:
it uses forbidden argument types (QuerySet)
it calls not pure functions (print)
it has no return
```
Usage inside Python code sample:
```jupyterpython
>>> import ast
>>> from mr_propper.utils import is_function_pure
>>> funcdef = ast.parse('''
def add_one(n: int) -> int:
return n + 1
''').body[0]
>>> is_function_pure(funcdef)
True
>>> is_function_pure(funcdef, with_errors=True)
(True, [])
```
## Parameters
CLI interface:
- `filepath`: path to .py file to check (directories are not supported for now);
- `--recursive`: require inner calls to be pure for function pureness.
## Code prerequisites
1. Python 3.7+;
1. Functions are fully type-annotated;
1. No dynamic calls (like `getattr(sender, 'send_' + message_type)(message)`).
## Contributing
We would love you to contribute to our project. It's simple:
1. Create an issue with bug you found or proposal you have.
Wait for approve from maintainer.
1. Create a pull request. Make sure all checks are green.
1. Fix review comments if any.
1. Be awesome.
Here are useful tips:
- You can run all checks and tests with `make check`.
Please do it before TravisCI does.
- We use [BestDoctor python styleguide](https://github.com/best-doctor/guides/blob/master/guides/en/python_styleguide.md).
- We respect [Django CoC](https://www.djangoproject.com/conduct/).
Make soft, not bullshit.
%prep
%autosetup -n mr-proper-0.0.7
%build
%py3_build
%install
%py3_install
install -d -m755 %{buildroot}/%{_pkgdocdir}
if [ -d doc ]; then cp -arf doc %{buildroot}/%{_pkgdocdir}; fi
if [ -d docs ]; then cp -arf docs %{buildroot}/%{_pkgdocdir}; fi
if [ -d example ]; then cp -arf example %{buildroot}/%{_pkgdocdir}; fi
if [ -d examples ]; then cp -arf examples %{buildroot}/%{_pkgdocdir}; fi
pushd %{buildroot}
if [ -d usr/lib ]; then
find usr/lib -type f -printf "/%h/%f\n" >> filelist.lst
fi
if [ -d usr/lib64 ]; then
find usr/lib64 -type f -printf "/%h/%f\n" >> filelist.lst
fi
if [ -d usr/bin ]; then
find usr/bin -type f -printf "/%h/%f\n" >> filelist.lst
fi
if [ -d usr/sbin ]; then
find usr/sbin -type f -printf "/%h/%f\n" >> filelist.lst
fi
touch doclist.lst
if [ -d usr/share/man ]; then
find usr/share/man -type f -printf "/%h/%f.gz\n" >> doclist.lst
fi
popd
mv %{buildroot}/filelist.lst .
mv %{buildroot}/doclist.lst .
%files -n python3-mr-proper -f filelist.lst
%dir %{python3_sitelib}/*
%files help -f doclist.lst
%{_docdir}/*
%changelog
* Sun Apr 23 2023 Python_Bot <Python_Bot@openeuler.org> - 0.0.7-1
- Package Spec generated
|