1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
|
ERROR at //build/config/BUILDCONFIG.gn:533:5: Dependency not allowed.
target(_target_type, target_name) {
^----------------------------------
The item //third_party/webrtc/pc:media_protocol_names
can not depend on //third_party/abseil-cpp/absl/strings:string_view
because it is not in //third_party/abseil-cpp/absl/strings:string_view's visibility list: [
//third_party/abseil-cpp/*
//third_party/googletest/*
//third_party/webrtc/rtc_tools:frame_analyzer
//third_party/webrtc/rtc_tools:rtp_generator
//third_party/webrtc/rtc_tools:video_replay
//chromecast/internal/*
//libassistant/*
//components/optimization_guide/internal/*
]
Absl used to have absl_deps, but that got removed with:
commit 99c519b3fdac0cbedaecead04a841e89a5f0f69b
Author: Florent Castelli <orphis@webrtc.org>
Date: Thu May 23 11:21:53 2024 +0000
Mass removal of absl_deps in all BUILD.gn files
Newer gn is fine with s/absl_deps/deps/, but bookworm's gn
requires manually changing the visibility of all the absl
libs.
--- a/third_party/abseil-cpp/absl/strings/BUILD.gn
+++ b/third_party/abseil-cpp/absl/strings/BUILD.gn
@@ -8,6 +8,7 @@ import("//third_party/abseil-cpp/absl.gn
absl_source_set("string_view") {
sources = [ "string_view.cc" ]
public = [ "string_view.h" ]
+ visibility = [ "*" ]
deps = [
"//third_party/abseil-cpp/absl/base",
"//third_party/abseil-cpp/absl/base:config",
@@ -58,6 +59,7 @@ absl_source_set("strings") {
"strip.h",
"substitute.h",
]
+ visibility = [ "*" ]
public_deps = [
# string_view.h was once part of :strings, so string_view.h is
# re-exported for backwards compatibility.
--- a/third_party/abseil-cpp/absl/types/BUILD.gn
+++ b/third_party/abseil-cpp/absl/types/BUILD.gn
@@ -61,6 +61,7 @@ absl_test("span_test") {
absl_source_set("optional") {
sources = [ "internal/optional.h" ]
public = [ "optional.h" ]
+ visibility = [ "*" ]
public_deps = [
":bad_optional_access",
"//third_party/abseil-cpp/absl/base:base_internal",
@@ -90,6 +91,7 @@ absl_source_set("bad_variant_access") {
absl_source_set("variant") {
sources = [ "internal/variant.h" ]
public = [ "variant.h" ]
+ visibility = [ "*" ]
public_deps = [
":bad_variant_access",
"//third_party/abseil-cpp/absl/base:base_internal",
--- a/third_party/abseil-cpp/absl/meta/BUILD.gn
+++ b/third_party/abseil-cpp/absl/meta/BUILD.gn
@@ -6,6 +6,7 @@ import("//third_party/abseil-cpp/absl.gn
absl_source_set("type_traits") {
public = [ "type_traits.h" ]
+ visibility = [ "*" ]
deps = [
"//third_party/abseil-cpp/absl/base:config",
"//third_party/abseil-cpp/absl/base:core_headers",
--- a/third_party/abseil-cpp/absl/base/BUILD.gn
+++ b/third_party/abseil-cpp/absl/base/BUILD.gn
@@ -39,6 +39,7 @@ absl_source_set("no_destructor") {
absl_source_set("nullability") {
sources = [ "internal/nullability_impl.h" ]
public = [ "nullability.h" ]
+ visibility = [ "*" ]
deps = [
":config",
":core_headers",
@@ -82,6 +83,7 @@ absl_source_set("config") {
"options.h",
"policy_checks.h",
]
+ visibility = [ "*" ]
}
absl_source_set("cycleclock_internal") {
@@ -117,6 +119,7 @@ absl_source_set("core_headers") {
"port.h",
"thread_annotations.h",
]
+ visibility = [ "*" ]
public_deps = [ ":config" ]
}
--- a/third_party/abseil-cpp/absl/algorithm/BUILD.gn
+++ b/third_party/abseil-cpp/absl/algorithm/BUILD.gn
@@ -6,11 +6,13 @@ import("//third_party/abseil-cpp/absl.gn
absl_source_set("algorithm") {
public = [ "algorithm.h" ]
+ visibility = [ "*" ]
deps = [ "//third_party/abseil-cpp/absl/base:config" ]
}
absl_source_set("container") {
public = [ "container.h" ]
+ visibility = [ "*" ]
deps = [
":algorithm",
"//third_party/abseil-cpp/absl/base:config",
--- a/third_party/abseil-cpp/absl/container/BUILD.gn
+++ b/third_party/abseil-cpp/absl/container/BUILD.gn
@@ -50,6 +50,7 @@ absl_source_set("inlined_vector_internal
absl_source_set("inlined_vector") {
public = [ "inlined_vector.h" ]
+ visibility = [ "*" ]
deps = [
":inlined_vector_internal",
"//third_party/abseil-cpp/absl/algorithm",
--- a/third_party/abseil-cpp/absl/numeric/BUILD.gn
+++ b/third_party/abseil-cpp/absl/numeric/BUILD.gn
@@ -9,6 +9,7 @@ absl_source_set("bits") {
"bits.h",
"internal/bits.h",
]
+ visibility = [ "*" ]
deps = [
"//third_party/abseil-cpp/absl/base:config",
"//third_party/abseil-cpp/absl/base:core_headers",
--- a/third_party/abseil-cpp/absl/functional/BUILD.gn
+++ b/third_party/abseil-cpp/absl/functional/BUILD.gn
@@ -7,6 +7,7 @@ import("//third_party/abseil-cpp/absl.gn
absl_source_set("any_invocable") {
sources = [ "internal/any_invocable.h" ]
public = [ "any_invocable.h" ]
+ visibility = [ "*" ]
deps = [
"//third_party/abseil-cpp/absl/base:base_internal",
"//third_party/abseil-cpp/absl/base:config",
@@ -34,6 +35,7 @@ absl_test("any_invocable_test") {
absl_source_set("bind_front") {
sources = [ "internal/front_binder.h" ]
public = [ "bind_front.h" ]
+ visibility = [ "*" ]
deps = [
"//third_party/abseil-cpp/absl/base:base_internal",
"//third_party/abseil-cpp/absl/container:compressed_tuple",
--- a/third_party/abseil-cpp/absl/memory/BUILD.gn
+++ b/third_party/abseil-cpp/absl/memory/BUILD.gn
@@ -6,6 +6,7 @@ import("//third_party/abseil-cpp/absl.gn
absl_source_set("memory") {
public = [ "memory.h" ]
+ visibility = [ "*" ]
deps = [
"//third_party/abseil-cpp/absl/base:core_headers",
"//third_party/abseil-cpp/absl/meta:type_traits",
--- a/third_party/abseil-cpp/absl/cleanup/BUILD.gn
+++ b/third_party/abseil-cpp/absl/cleanup/BUILD.gn
@@ -16,6 +16,7 @@ absl_source_set("cleanup_internal") {
absl_source_set("cleanup") {
public = [ "cleanup.h" ]
+ visibility = [ "*" ]
deps = [
":cleanup_internal",
"//third_party/abseil-cpp/absl/base:config",
|
