summaryrefslogtreecommitdiff
path: root/libwebsocketpp-dev.spec
diff options
context:
space:
mode:
Diffstat (limited to 'libwebsocketpp-dev.spec')
-rw-r--r--libwebsocketpp-dev.spec27
1 files changed, 19 insertions, 8 deletions
diff --git a/libwebsocketpp-dev.spec b/libwebsocketpp-dev.spec
index 889b585..56d78cf 100644
--- a/libwebsocketpp-dev.spec
+++ b/libwebsocketpp-dev.spec
@@ -52,14 +52,25 @@ websocketpp::websocketpp) needed to build applications against WebSocket++.
# Boost / OpenSSL / zlib are only probed by upstream when tests or examples are
# enabled; both are disabled so the shipped artifacts have no such linkage.
#
-# NOTE (openEuler 24.03 LTS SP3 build fix, build 112495): the openEuler %cmake
-# macro configures IN SOURCE (no -B/-S), so the out-of-source build directory
-# %{_vpath_builddir} (= %{_target_platform}, e.g. noarch-openEuler-linux-gnu)
-# never exists and %cmake_build aborts with
-# Error: .../noarch-openEuler-linux-gnu is not a directory
-# Likewise %cmake_install would target that missing directory. Hence drive the
-# already-configured in-source tree with the plain make macros; this is the same
-# pattern used by the other header-only cpp packages built in this chroot.
+# NOTE (openEuler 24.03 LTS SP3, builds 112495/112498): the openEuler cmake
+# macro configures the tree IN SOURCE - its cmake invocation carries no -S/-B
+# and CMake reports "Build files have been written to: <srcdir>". The vpath
+# build directory that the plain cmake-driven build/install macros operate on
+# (noarch-openEuler-linux-gnu) is therefore never created, and those macros
+# abort with "Error: ... is not a directory" (build 112495). So drive the
+# already-configured in-source tree with the generic make macros, which is also
+# what the other header-only cpp packages in this chroot do.
+#
+# IMPORTANT: write NO bare percent-macro reference in this comment. RPM
+# expands macros even inside spec comments, and the openEuler cmake build and
+# install macros are defined with a multi-line body. The text that follows
+# such a reference in a comment is then emitted on its own line of the
+# generated build script and gets EXECUTED as a command. Build 112498 died
+# exactly that way: the tail of the old comment here ("aborts with") was
+# appended to the cmake build macro expansion, so a stray
+# 'cmake --build noarch-openEuler-linux-gnu -j4 --verbose aborts with' ran
+# before the real build steps below and aborted the build with
+# 'Unknown argument aborts'.
%cmake \
-DBUILD_EXAMPLES=OFF \
-DBUILD_TESTS=OFF